Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all-time dark Openboard settings for Android 12+ #69

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

BlackyHawky
Copy link
Contributor

@BlackyHawky BlackyHawky commented Aug 8, 2023

This PR fixes issue #751:
Describe the bug
On my device I'm using light mode, however, when opening the OpenBoard settings they are displayed in dark mode.


I confirmed this bug on my Samsung Tablet with Android 13 too.

  • Screenshot before:

  • Screenshot after:

Of course, when you use your tablet in dark mode, the Openboard settings follow the dark mode:

  

@RHJihan
Copy link
Contributor

RHJihan commented Aug 9, 2023

Thanks. Tested on One UI 5.1 (Android 13). Works fine.

@Helium314
Copy link
Owner

Of course, when you use your tablet in dark mode, the Openboard settings follow the dark mode

Do you know why this is?
I would expect values-v31 (now explicitly using light theme) to take precedence over values-night-v21. But maybe I'm wrong here

@Helium314 Helium314 merged commit acaf426 into Helium314:new Aug 9, 2023
@BlackyHawky
Copy link
Contributor Author

BlackyHawky commented Aug 9, 2023

Of course, when you use your tablet in dark mode, the Openboard settings follow the dark mode

Do you know why this is?
I would expect values-v31 (now explicitly using light theme) to take precedence over values-night-v21. But maybe I'm wrong here

Normally it's impossible for a phone with a version below Android 13 to choose the values-v31 folder settings.

I've just tested with my Android 10 phone and I can confirm that the blue color is different from the one defined in the platform-themes.xml file in the values-v31 folder.

I agree that it's strange that we don't need to create a values-night-v31 folder.
I haven't looked into it.

@BlackyHawky BlackyHawky deleted the Settings_Android12 branch August 9, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants